Add building and container recipes#31
Closed
AbdulRehman-Fayyaz wants to merge 2 commits intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#31AbdulRehman-Fayyaz wants to merge 2 commits intoSimulation-Software-Engineering:mainfrom
AbdulRehman-Fayyaz wants to merge 2 commits intoSimulation-Software-Engineering:mainfrom
Conversation
AbdulRehman-Fayyaz
force-pushed
the
main
branch
from
2d14cd9 to
4b6eac8
Compare
Author
|
GitLab name: @ rehmanal |
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Everything looks good here and works, thanks!
| make install | ||
|
|
||
| # Set environment variables | ||
| ENV LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH |
There was a problem hiding this comment.
FYI, LD_LIBRARY_PATH at the right-hand side is undefined at this point.
|
|
||
| # Set environment variables | ||
| ENV LD_LIBRARY_PATH=/usr/local/lib:$LD_LIBRARY_PATH | ||
| WORKDIR /cmake-exercise No newline at end of file |
There was a problem hiding this comment.
If there is a WORKDIR set, I would expect it to exist and have contents, independently of the user-defined mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request completes the Fight with CMake exercise.
Changes Implemented:
Dockerfilebased onubuntu:24.04.deal.ii,mpi,trilinos,petsc, andtbb.yaml-cppversion 0.6.3 from source as requested.CMakeLists.txtto linkBoost::filesystem,MPI,OpenMP, andyaml-cpp.deal_ii_setup_target(main)macro to correctly handle transitive dependencies (Trilinos, PETSc, TBB) for the FEM solver.main.cpp.Verification:
build_and_run.shexecutes without errors and produces the expected output for all modules (Flatset, Filesystem, FEM)../build/main yamlParser/config.yml.